From c47dc67a8463843f23782cd89199ac8171d4bfcf Mon Sep 17 00:00:00 2001 From: ValueOn AG Date: Sun, 26 Apr 2026 08:31:31 +0200 Subject: [PATCH] cleanup internal marked exports --- .../editor/Automation2FlowEditor.module.css | 391 +++++++++++++- .../editor/Automation2FlowEditor.tsx | 18 +- .../FlowEditor/editor/CanvasHeader.tsx | 402 +++++++------- .../FlowEditor/editor/NodeConfigPanel.tsx | 89 +++- .../FeatureInstancePicker.tsx | 158 ++++++ .../nodes/frontendTypeRenderers/index.tsx | 2 + .../FlowEditor/nodes/shared/DataPicker.tsx | 58 +-- .../nodes/shared/RequiredAttributePicker.tsx | 90 +++- .../nodes/shared/paramValidation.test.ts | 14 + .../nodes/shared/paramValidation.ts | 10 +- .../FormGeneratorTable.module.css | 6 - .../FormGeneratorTable/FormGeneratorTable.tsx | 291 ++++------- src/hooks/useMandates.ts | 5 +- src/pages/AutomationsDashboardPage.tsx | 53 +- src/pages/admin/AdminUsersPage.tsx | 3 +- src/pages/basedata/ConnectionsPage.tsx | 5 +- src/pages/basedata/FilesPage.tsx | 6 +- src/pages/basedata/PromptsPage.tsx | 6 +- .../views/commcoach/CommcoachKeepAlive.tsx | 6 + .../GraphicalEditorKeepAlive.test.tsx | 96 ++++ .../GraphicalEditorKeepAlive.tsx | 22 +- .../GraphicalEditorTemplatesPage.tsx | 3 +- .../trustee/TrusteePositionDocumentsView.tsx | 38 +- .../trustee/dataTables/TrusteeDataTab.tsx | 3 +- .../views/workspace/WorkspaceKeepAlive.tsx | 13 +- tsc-out.txt | 489 ------------------ 26 files changed, 1246 insertions(+), 1031 deletions(-) create mode 100644 src/components/FlowEditor/nodes/frontendTypeRenderers/FeatureInstancePicker.tsx create mode 100644 src/pages/views/graphicalEditor/GraphicalEditorKeepAlive.test.tsx delete mode 100644 tsc-out.txt diff --git a/src/components/FlowEditor/editor/Automation2FlowEditor.module.css b/src/components/FlowEditor/editor/Automation2FlowEditor.module.css index 5f1e938..67a4261 100644 --- a/src/components/FlowEditor/editor/Automation2FlowEditor.module.css +++ b/src/components/FlowEditor/editor/Automation2FlowEditor.module.css @@ -256,6 +256,225 @@ background: var(--bg-primary, #fff); } +/* Toolbar: context (load + name) is fluid with ellipsis; actions stay right-aligned. */ +.canvasHeaderRow { + display: grid; + grid-template-columns: minmax(0, 1fr) auto; + gap: 0.75rem; + align-items: center; + width: 100%; +} + +@media (max-width: 900px) { + .canvasHeaderRow { + grid-template-columns: 1fr; + } +} + +.canvasHeaderContext { + display: flex; + align-items: center; + gap: 0.5rem; + min-width: 0; + flex: 1; +} + +/* Closed setNameValue(e.target.value)} - onBlur={_commitNameEdit} - onKeyDown={(e) => { if (e.key === 'Enter') _commitNameEdit(); if (e.key === 'Escape') setEditingName(false); }} - style={{ padding: '0.25rem 0.4rem', fontSize: '0.95rem', fontWeight: 600, border: '1px solid var(--primary-color, #007bff)', borderRadius: 4, outline: 'none', minWidth: 140, maxWidth: 300 }} - /> - ) : ( -

- {currentWorkflow.label} -

- ) - ) : ( -

- {t('Neuer Workflow')} -

- )} - {onWorkflowSettings && ( - - - {newMenuOpen && ( -
- - {onNewFromTemplate && ( - - )} -
)} - - - {onAutoLayout && ( - - )} - - {/* Save as template */} - {currentWorkflowId && onSaveAsTemplate && ( -
- - {templateMenuOpen && ( -
- {(['user', 'instance', 'mandate'] as const).map((s) => ( +
+
+
+ + +
+ {newMenuOpen && ( +
+ + {onNewFromTemplate && ( - ))} + )}
)}
- )} - - - {onToggleChat && ( - - )} + + {onAutoLayout && ( + + )} + + {currentWorkflowId && onSaveAsTemplate && ( +
+ + {templateMenuOpen && ( +
+ {(['user', 'instance', 'mandate'] as const).map((s) => ( + + ))} +
+ )} +
+ )} + + + {onToggleChat && ( + + )} + {_isSysAdmin && onVerboseSchemaChange && ( + + )} +
- {/* Version Selector */} {currentWorkflowId && versions && versions.length > 0 && ( -
- {t('Version:')} +
+ {t('Version:')} + * + * The bound value is a plain `` string so backend adapters can keep + * using `featureInstanceId` lookups unchanged. Type stays + * `FeatureInstanceRef[]` on the parameter so DataPicker / RequiredAttributePicker + * filter correctly. + */ + +import React from 'react'; +import { useLanguage } from '../../../../providers/language/LanguageContext'; +import type { FieldRendererProps } from './index'; + +type FeatureInstanceOption = { id: string; label: string }; + +export const FeatureInstancePicker: React.FC = ({ + param, + value, + onChange, + instanceId, + request, +}) => { + const { t } = useLanguage(); + const featureCode = + (param.frontendOptions?.featureCode as string | undefined) || undefined; + const [instances, setInstances] = React.useState([]); + const [loading, setLoading] = React.useState(false); + const [loadError, setLoadError] = React.useState(null); + const autoSingleRef = React.useRef(false); + + React.useEffect(() => { + if (!instanceId || !request || !featureCode) return; + setLoading(true); + setLoadError(null); + request({ + url: `/api/workflows/${instanceId}/options/feature.instance?featureCode=${encodeURIComponent(featureCode)}`, + method: 'get', + }) + .then((res: unknown) => { + const data = res as { options?: Array<{ value: string; label: string }> }; + setInstances((data?.options || []).map((o) => ({ id: o.value, label: o.label }))); + }) + .catch((err: unknown) => { + console.error('FeatureInstancePicker: failed to load instances', err); + setInstances([]); + setLoadError(err instanceof Error ? err.message : String(err)); + }) + .finally(() => setLoading(false)); + }, [instanceId, request, featureCode]); + + React.useEffect(() => { + if (instances.length !== 1 || autoSingleRef.current) return; + if (value !== '' && value !== undefined && value !== null) return; + autoSingleRef.current = true; + onChange(instances[0].id); + }, [instances, value, onChange]); + + const strVal = typeof value === 'string' ? value : ''; + const codeLabel = featureCode ?? t('Feature'); + + return ( +
+ + {loading && ( +
{t('Lade…')}
+ )} + {!loading && instances.length === 0 && !loadError && ( +
+ {t('Keine {code}-Instanz im aktiven Mandanten — bitte in der Admin-Konsole anlegen.', { code: codeLabel })} +
+ )} + {!loading && instances.length === 1 && ( +
+ {instances[0].label} +
+ )} + {!loading && instances.length > 1 && ( + + )} + {loadError && ( +
+ {t('Mandanten-Liste konnte nicht geladen werden')} +
+ )} +
+ ); +}; + +export default FeatureInstancePicker; diff --git a/src/components/FlowEditor/nodes/frontendTypeRenderers/index.tsx b/src/components/FlowEditor/nodes/frontendTypeRenderers/index.tsx index a910ca6..fb33a03 100644 --- a/src/components/FlowEditor/nodes/frontendTypeRenderers/index.tsx +++ b/src/components/FlowEditor/nodes/frontendTypeRenderers/index.tsx @@ -31,6 +31,7 @@ import { toApiGraph } from '../shared/graphUtils'; import { postUpstreamPaths } from '../../../../api/workflowApi'; import type { CanvasNode } from '../../editor/FlowCanvas'; import { DataRefRenderer } from './DataRefRenderer'; +import { FeatureInstancePicker } from './FeatureInstancePicker'; const TextInput: React.FC = ({ param, value, onChange }) => (
@@ -755,6 +756,7 @@ export const FRONTEND_TYPE_RENDERERS: Record = { hidden: HiddenInput, dataRef: DataRefRenderer, userConnection: ConnectionPicker, + featureInstance: FeatureInstancePicker, sharepointFolder: SharepointPathPicker, sharepointFile: SharepointPathPicker, clickupList: FolderPicker, diff --git a/src/components/FlowEditor/nodes/shared/DataPicker.tsx b/src/components/FlowEditor/nodes/shared/DataPicker.tsx index c1ea657..4edadc7 100644 --- a/src/components/FlowEditor/nodes/shared/DataPicker.tsx +++ b/src/components/FlowEditor/nodes/shared/DataPicker.tsx @@ -6,6 +6,7 @@ */ import React, { useMemo, useState } from 'react'; +import { createPortal } from 'react-dom'; import { createRef, createSystemVar, type DataRef, type SystemVarRef, isCompatible } from './dataRef'; import { useAutomation2DataFlow } from '../../context/Automation2DataFlowContext'; import type { GraphDefinedSchemaRef, NodeType, PortSchema } from '../../../../api/workflowApi'; @@ -254,33 +255,35 @@ export const DataPicker: React.FC = ({ open, onClose(); }; - return ( -
-
e.stopPropagation()}> + const _dialog = ( +
e.key === 'Escape' && onClose()} + role="presentation" + > +
e.stopPropagation()} + role="dialog" + aria-modal="true" + aria-labelledby="automation2DataPickerTitle" + >
-

+

{t('Datenquelle wählen')} {expectedParamType && ( {expectedParamType} )}

-
+
{expectedParamType && ( -