PowerOn/service-teams-browser-bot
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: _isChatPanelOpen false positive - [role=log] matched captions panel, not chat

Browse source 
Made-with: Cursor
This commit is contained in:
ValueOn AG 2026-03-07 01:27:47 +01:00
parent 6e444e83d0
commit f8bd473008
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/bot/chatProcedure.ts
View file

@ -67,41 +67,40 @@ export class ChatProcedure {
*/ */
private async _isChatPanelOpen(): Promise<boolean> { private async _isChatPanelOpen(): Promise<boolean> {
return this._page.evaluate(() => { return this._page.evaluate(() => {
// 1. Chat button toggle state // 1. Chat button aria-pressed state (most reliable when available)
const chatBtn = document.querySelector('button[id="chat-button"], button[data-tid="chat-button"]') as HTMLElement | null; const chatBtn = document.querySelector('#chat-button, button[id="chat-button"]') as HTMLElement | null;
if (chatBtn?.getAttribute('aria-pressed') === 'true') return true; if (chatBtn?.getAttribute('aria-pressed') === 'true') return true;
// 2. Chat input visible (multiple Teams UI variants) // 2. Chat input / compose box visible (definitive proof the chat panel is open)
const inputSelectors = [ const inputSelectors = [
'[data-tid="ckeditor-replyConversation"]', '[data-tid="ckeditor-replyConversation"]',
'div[role="textbox"][data-tid*="chat"]', 'div[role="textbox"][data-tid*="chat"]',
'div[role="textbox"][data-tid*="message"]',
'div[role="textbox"][aria-label*="message" i]', 'div[role="textbox"][aria-label*="message" i]',
'div[role="textbox"][aria-label*="Nachricht" i]', 'div[role="textbox"][aria-label*="Nachricht" i]',
'[contenteditable="true"][aria-label*="message" i]', '[contenteditable="true"][aria-label*="message" i]',
'[contenteditable="true"][aria-label*="Nachricht" i]', '[contenteditable="true"][aria-label*="Nachricht" i]',
'[placeholder*="message" i]',
'[placeholder*="Nachricht" i]',
'div[aria-label="Type a message"]', 'div[aria-label="Type a message"]',
'div[aria-label*="Neue Nachricht" i]',
]; ];
for (const sel of inputSelectors) { for (const sel of inputSelectors) {
const el = document.querySelector(sel) as HTMLElement | null; const el = document.querySelector(sel) as HTMLElement | null;
if (el && el.offsetHeight > 0) return true; if (el && el.offsetHeight > 0) return true;
} }
// 3. Message list container visible // 3. Chat-specific containers (NOT [role="log"] which also matches captions)
const listSelectors = [ const chatContainerSelectors = [
'[data-tid="message-pane-list"]', '[data-tid="message-pane-list"]',
'[data-tid="chat-pane-list"]', '[data-tid="chat-pane-list"]',
'[data-tid="chat-pane"]', '[data-tid="chat-pane"]',
'.ts-message-list-container', '.ts-message-list-container',
'[role="log"]',
]; ];
for (const sel of listSelectors) { for (const sel of chatContainerSelectors) {
const el = document.querySelector(sel) as HTMLElement | null; const el = document.querySelector(sel) as HTMLElement | null;
if (el && el.offsetHeight > 50) return true; if (el && el.offsetHeight > 50) return true;
} }
// 4. "Meeting chat" heading visible // 4. "Meeting chat" / "Besprechungschat" heading visible
const headings = document.querySelectorAll('h2, h3, [role="heading"]'); const headings = document.querySelectorAll('h2, h3, [role="heading"]');
for (const h of Array.from(headings)) { for (const h of Array.from(headings)) {
const txt = (h as HTMLElement).innerText?.toLowerCase() || ''; const txt = (h as HTMLElement).innerText?.toLowerCase() || '';